[6.0] Removes fetchExtensionCompatibility in UpdateController class#45436
Merged
Bodge-IT merged 3 commits intojoomla:6.0-devfrom Jun 12, 2025
Merged
[6.0] Removes fetchExtensionCompatibility in UpdateController class#45436Bodge-IT merged 3 commits intojoomla:6.0-devfrom
Bodge-IT merged 3 commits intojoomla:6.0-devfrom
Conversation
Member
|
can we please fix the camelCase for the batch function... it's not a b/c break and makes it constant to our code base and would be a good point in time before documentation |
Member
Author
|
I'm not sure if it is like that because of the task parameter in the url? Did you test it with the camelCase name? |
Contributor
|
@laoneo How would someone test this? |
Member
Author
|
As this function is not used in core at all, there is nothing to test. |
Member
Author
|
The closest you can do is to case insensitive search for the function name. |
rdeutz
approved these changes
May 28, 2025
HLeithner
approved these changes
May 28, 2025
Contributor
|
I have tested this item ✅ successfully on 2e596a8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
Contributor
|
I have tested this item ✅ successfully on 2e596a8 git clone https://github.com/joomla/joomla-cms -b 6.0-dev 60
# test before the PR
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
60/administrator/components/com_joomlaupdate/src/Controller/UpdateController.php: public function fetchExtensionCompatibility()
60/administrator/components/com_joomlaupdate/src/Model/UpdateModel.php: * Called by controller's fetchExtensionCompatibility, which is called via AJAX.
# Apply the PR
gh pr checkout 45436
# Retest
find 60 -name \*.php | xargs grep -i fetchExtensionCompatibility
# nothing found :)This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45436. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Removes
fetchExtensionCompatibilityinUpdateControllerclass as it is not used sinceTesting Instructions
Install test sample data and browse around the front end and back end.
Actual result BEFORE applying this Pull Request
All is working.
Expected result AFTER applying this Pull Request
All is working.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Removes fetchExtensionCompatibility in UpdateController class Manual#460
No documentation changes for manual.joomla.org needed