[5.3] Set http status header for XML/feed responses

[ManuelHu]

Pull Request for Issue #45398.

Summary of Changes

set the error code on the HTTP response

this is similar to the other error renderes (i.e. copied from https://github.com/joomla/joomla-cms/blob/5.3-dev/libraries/src/Error/Renderer/JsonRenderer.php)

Testing Instructions

1. set a menu item that shows an article as the home menu item
   2, open https://<your-site>/?format=feed -- of course, this is not a useful feed link (I know that; thats the whole point.

2. see a response such as

<?xml version="1.0" encoding="UTF-8"?>
<error>
	<code>404</code>
	<message>View nicht gefunden [Name, Typ, Präfix]: article, feed, site</message>
</error>

4. open the browser DevTools to see the http status code reported from the server

Actual result BEFORE applying this Pull Request

the HTTP response status is 200

Expected result AFTER applying this Pull Request

the HTTP response status (not the one listed as <code>404</code>) is actually 404

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Not sure but is it not enough to add this single line in the function

\Joomla\CMS\Factory::getApplication()->setHeader('status', $error->getCode());

[ManuelHu]

well, yes, if we assume that

• XML is only ever sent over HTTP (i.e. CLIApplication has no setHeader method)
  I am not sure if this is the case?
• and that every exception sets a HTTP status (which is not the case). The default value is 0, and 0 is not a valid HTTP status

note: a similar check is not only implemented in JsonRenderer, but also in ErrorDocument

joomla-cms/libraries/src/Document/ErrorDocument.php

Lines 119 to 131 in 74e625d

	$status = $this->_error->getCode();
	if ($status < 400 || $status > 599) {
	$status = 500;
	}
	$errorReporting = CmsFactory::getApplication()->get('error_reporting');
	if ($errorReporting === "development" || $errorReporting === "maximum") {
	$status .= ' ' . str_replace("\n", ' ', $this->_error->getMessage());
	}
	CmsFactory::getApplication()->setHeader('status', $status);

also in the joomla-framework/application documentation:
https://github.com/joomla-framework/application/blob/e063a4a308729b930d853e29a9f7c303cac68629/README.md?plain=1#L54

However, this check is missing in other places. Also note, I am not an export in this (all of this just based on my code reviw of the last day), so I am not really sure what to decide here.

[laoneo]

The instanceof check is fine, but I think ->setHeader('status', $error->getCode() < 400 ? 500 : $error->getCode()); would be enough. Or do you see an issue with it?

[ManuelHu]

No, this should be equivalent in all typical cases. This very verbose code is just the same as already in the Json response, but I can certainly simplify the code.

[ceford]

I have tested this item ✅ successfully on fbc2426

I see the network response code change from 200 to 404 after applying the patch and the Firefox Browser Tools show a problem icon. So it works as described but I can't comment on the experts comments.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45419.}

[MacJoom]

I have tested this item ✅ successfully on fbc2426

On 5.3.3 - Status changed to 404 after applying Patch

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45419.}

[exlemor]

I have tested this item ✅ successfully on 8ab15d6

I have tested this successfully (thanks @MacJoom), @ManuelHu

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45419.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45419.}

[rdeutz]

Thanks