Skip to content

Comments

[5.3] HTTP Headers - CSP - Policy Directive: order + fancy select#45407

Merged
laoneo merged 2 commits intojoomla:5.3-devfrom
pe7er:fix-httpheaders-csp-policy-alpha
Apr 29, 2025
Merged

[5.3] HTTP Headers - CSP - Policy Directive: order + fancy select#45407
laoneo merged 2 commits intojoomla:5.3-devfrom
pe7er:fix-httpheaders-csp-policy-alpha

Conversation

@pe7er
Copy link
Contributor

@pe7er pe7er commented Apr 28, 2025

This PR improves the HTTP Headers system plugin under the Content Security Policy the "Policy Directive" drop down list.

Summary of Changes

The PR orders the options in the Policy Directive drop down box alphabetically and adds a fancy select layout to make it easier to find an option.

Testing Instructions

In Joomla back-end go to System > Plugins > "System - HTTP Headers" > go to the "Content-Security-Policy (CSP)" tab.
Choose for "Content Security Policy (CSP)": select "Enable", Add Directive: click the + button
Click on the Policy Directive drop down box.

Actual result BEFORE applying this Pull Request

Before the PR, the list is not ordered alphabetically.

http-headers-csp-before-pr

Expected result AFTER applying this Pull Request

After applying this PR, the list is ordered alphabetically.

http-headers-csp-alphabetical

And the list has a fancy select layout: an extra search option to make it easier to find the right options

http-headers-csp-fancy-select

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@rachelwalraven
Copy link

I have tested this item ✅ successfully on fc78b62

Installed the fix and got the result as shown in the description.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45407.

@Kleijson
Copy link

I have tested this item ✅ successfully on fc78b62

It works as stated


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45407.

@QuyTon
Copy link
Contributor

QuyTon commented Apr 28, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45407.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 28, 2025
@laoneo laoneo merged commit 78d2b75 into joomla:5.3-dev Apr 29, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 29, 2025
@laoneo
Copy link
Member

laoneo commented Apr 29, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.1 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants