[5.3] Show correct custom fields when creating article after filtering by multiple categories#45353
Merged
richard67 merged 5 commits intojoomla:5.3-devfrom Apr 20, 2025
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 56c2e62 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45353. |
|
I also have tested this item ✅ successfully on 56c2e62 Functionality works as described |
QuyTon
reviewed
Apr 19, 2025
administrator/components/com_content/src/Model/ArticleModel.php
Outdated
Show resolved
Hide resolved
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45353. |
Member
|
I've just double-checked this PR and it works and seems not to break anything else. |
Member
|
Thanks all (author and testers). |
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 23, 2025
…g by multiple categories (joomla#45353) Pull Request for Issue joomla#45303 This PR fixes a bug where creating a new article after filtering by multiple categories (e.g. "News" and "Events") incorrectly displays all custom fields from all those categories on the "Fields" tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #45303
Summary of Changes
This PR fixes a bug where creating a new article after filtering by multiple categories (e.g. "News" and "Events") incorrectly displays all custom fields from all those categories on the "Fields" tab.
Joomla previously used the
catidfilter directly from user state or input, which led to ambiguous behavior when multiple categories were selected. This fix:category_idfilter is an arrayThis resolves #45303 and improves clarity and correctness of the custom field rendering in the admin UI.
Testing Instructions
events_title→ assigned to Eventsnews_title→ assigned to Newsevents_titleornews_title) should appear on the "Fields" tabActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentation
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed