[5.3] Optimize load of smart search plugins language

[Denitz]

Summary of Changes

Currently, \Joomla\Component\Finder\Administrator\Helper\LanguageHelper::loadPluginLanguage() uses a database query to get list of available finder plugins and next loads their language files.

This database query is useless because we can use native PluginHelper::getPlugin('finder') method which provides additional benefit (no extra database query is executed).

Additionally, the language load should be performed using system-wide $extension key like plg_finder_content to prevent duplicate language file load.

This method is called in all com_finder views plus mod_finder display, we can remove extra database and prevent duplicate language load.

Testing Instructions

Apply patch. Test smart search views in frontend, check smart search module display.

Actual result BEFORE applying this Pull Request

See extra database query like

SELECT `name`,`element`
FROM `jos_extensions`
WHERE `type` = 'plugin' AND `folder` = 'finder' AND `enabled` = 1

Expected result AFTER applying this Pull Request

All views and module work as usual, no extra database query

Link to documentations

• No documentation changes for docs.joomla.org needed
• No documentation changes for manual.joomla.org needed

[ceford]

With the patch applied I see that the quoted query disappears. However, in a page that has the query results and a query module I see the total number of queries increase! So, the patch is removing one query but creating more duplicates. Can you check and explain?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.}

[Denitz]

@ceford I can't confirm extra queries. Retested the patch and only see minus one query.

[ceford]

I have tested this item ✅ successfully on 38ef38b

I have rebuilt my test sites and tested this on the current 5 and 6 dev branches. I see the query disappear and I see no problems.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.}

[QuyTon]

I have tested this item ✅ successfully on 38ef38b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.}

[QuyTon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45345.}

[laoneo]

Thanks!