Skip to content

[5.3] Update to TinyMCE Danish translation (Fixed typo)#45317

Merged
tecpromotion merged 2 commits intojoomla:5.3-devfrom
dformdotdk:5.3-dev
Apr 18, 2025
Merged

[5.3] Update to TinyMCE Danish translation (Fixed typo)#45317
tecpromotion merged 2 commits intojoomla:5.3-devfrom
dformdotdk:5.3-dev

Conversation

@dformdotdk
Copy link
Contributor

Fixed misspelled language string in Danish translation

Pull Request for Issue # .

Summary of Changes

Fixed language string, line 123
"General": "Generelt",

Testing Instructions

Create a table in the editor, then select table properties.
Then select table properties and you see the language string in the popup

Skærmbillede 2025-04-11 kl  15 02 27

Actual result BEFORE applying this Pull Request

Generel was translated to Generet

Expected result AFTER applying this Pull Request

Correct translation of General to Generelt

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Apr 11, 2025
@tecpromotion tecpromotion changed the title Update to TinyMCE Danish translation (Fixed typo) [5.3] Update to TinyMCE Danish translation (Fixed typo) Apr 12, 2025
@ChristineWk
Copy link

I had to find my way around in Danish first. :-)
See image: I used NPM Package, but unfortunately it didn't work.

Screenshot 2025-04-12 132216

@tecpromotion
Copy link
Contributor

works for me

Bildschirmfoto 2025-04-17 um 17 39 28

@tecpromotion
Copy link
Contributor

I have tested this item ✅ successfully on 17f01f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45317.

@tecpromotion
Copy link
Contributor

I had to find my way around in Danish first. :-) See image: I used NPM Package, but unfortunately it didn't work.

@ChristineWk this worked for me.

  1. Please go to media/vendor/tinymce/langs and edit the da.js manually (you can also remove the min versions for testing)
  2. Please purge all caches

@ChristineWk
Copy link

@tecpromotion
a) Hmm, I've since reset everything to the original and now have 5.3.1-dev.
I'd have to reset everything to Danish, etc.
Probably the NPM too?

b) Your post: I can, of course, change the file. Then I wouldn't need a) anything else (apart from reinstalling the Danish language?)

@tecpromotion
Copy link
Contributor

b) Your post: I can, of course, change the file. Then I wouldn't need a) anything else (apart from reinstalling the Danish language?)

It is not necessary to reinstall the Danish language; you only need to change the word in da.js and reload the backend.

@ChristineWk
Copy link

I've now done point 1) via FTP.
Nevertheless, I enabled Danish (again) in the backend. Otherwise, I wouldn't have been able to check it. With success:

I found Gem&Luk/Grundinstillinger etc. :-)

Unfortunately, my image doesn't upload.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45317.

@ChristineWk
Copy link

Screenshot 2025-04-17 224210

@ChristineWk
Copy link

It didn't work via the issue tracker (image), but it did via Github.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45317.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 17f01f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45317.

@QuyTon
Copy link
Contributor

QuyTon commented Apr 17, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45317.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 17, 2025
@tecpromotion tecpromotion added this to the Joomla! 5.3.1 milestone Apr 18, 2025
@tecpromotion tecpromotion merged commit 3d475d1 into joomla:5.3-dev Apr 18, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 18, 2025
richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments