Skip to content

[5.3] - Respect individual width/height constraints in Media Action - Resize plugin #45311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richard67 merged 8 commits into from
Apr 19, 2025
Merged

[5.3] - Respect individual width/height constraints in Media Action - Resize plugin #45311

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c17b009
media resize plugin - allow width OR height instead of both
travisrisner Apr 10, 2025
4e0026d
update variables
travisrisner Apr 10, 2025
b9a54b0
Update plugins/media-action/resize/src/Extension/Resize.php
travisrisner Apr 10, 2025
1374907
Update plugins/media-action/resize/src/Extension/Resize.php
travisrisner Apr 14, 2025
09d2249
Update plugins/media-action/resize/src/Extension/Resize.php
QuyTon Apr 14, 2025
47a03fb
Merge branch '5.3-dev' into 5.3-dev-media-resize-plugin-fix
QuyTon Apr 18, 2025
62d3e1a
Merge branch '5.3-dev' into 5.3-dev-media-resize-plugin-fix
QuyTon Apr 18, 2025
f0a540e
Merge branch '5.3-dev' into 5.3-dev-media-resize-plugin-fix
richard67 Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions plugins/media-action/resize/src/Extension/Resize.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,18 @@ public function onContentBeforeSave(BeforeSaveEvent $event): void

$imgObject = new Image(imagecreatefromstring($item->data));

if ($imgObject->getWidth() < $this->params->get('batch_width', 0) && $imgObject->getHeight() < $this->params->get('batch_height', 0)) {
$maxWidth = (int) $this->params->get('batch_width', 0);
$maxHeight = (int) $this->params->get('batch_height', 0);
if (
!(($maxWidth && $imgObject->getWidth() > $maxWidth)
|| ($maxHeight && $imgObject->getHeight() > $maxHeight))
) {
return;
}

$imgObject->resize(
$this->params->get('batch_width', 0),
$this->params->get('batch_height', 0),
$maxWidth,
$maxHeight,
false,
Image::SCALE_INSIDE
);
Expand Down