Skip to content

[5.3] skip-to tooltip#45259

Merged
tecpromotion merged 2 commits intojoomla:5.3-devfrom
brianteeman:skipto
Apr 17, 2025
Merged

[5.3] skip-to tooltip#45259
tecpromotion merged 2 commits intojoomla:5.3-devfrom
brianteeman:skipto

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #45258.

Summary of Changes

The skip-to plugin when enabled on the frontend of your site has a css bug when displaying the keyboard shortcut

Testing Instructions

In the plugin setting for the skipto plugin make sure you enable it for both site and admin
In the front end tab to activate the plugin and hover to display the tooltip
image

If the text is longer than this (you're on a mac or using a different language) then the text is bigger than the background.

You can emulate this by creating a language string override for the string PLG_SYSTEM_SKIPTO_ACCESS_KEY in both site and admin so that you have a much longer string

As this is an scss change you will need to either run npm build:css or use a pre-built package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@ghost
Copy link

ghost commented Apr 1, 2025

I have tested this item ✅ successfully on 1469953

Thanks @brianteeman.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

@QuyTon
Copy link
Contributor

QuyTon commented Apr 1, 2025

I have tested this item ✅ successfully on 1469953


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

@QuyTon
Copy link
Contributor

QuyTon commented Apr 1, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45259.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 1, 2025
@tecpromotion tecpromotion enabled auto-merge (squash) April 17, 2025 13:34
@tecpromotion tecpromotion added this to the Joomla! 5.3.1 milestone Apr 17, 2025
@tecpromotion tecpromotion merged commit 2181f4a into joomla:5.3-dev Apr 17, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 17, 2025
@brianteeman brianteeman deleted the skipto branch April 17, 2025 14:25
@brianteeman
Copy link
Contributor Author

thanks

richard67 pushed a commit to richard67/joomla-cms that referenced this pull request Apr 23, 2025
Signed-off-by: BrianTeeman <brian@teeman.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants