[5.3] Clean Up File::upload method arguments

[joomdonation]

Pull Request for Issue # .

Summary of Changes

A minor bug fix/ clean up to File::upload() method arguments after we migrated from CMS FileSystem to Framework Filesystem package. Basically, unlike the CMS FileSystem package, the File::upload() method in Framework Filesystem package only has 3 parameters, see https://github.com/joomla-framework/filesystem/blob/3.x-dev/src/File.php#L285

So passing the fourth argument in File::upload call is not correct (PHP currently ignores the extra parameter, but it should be fixed anyway). Also, the third argument has same value with default value in method definition, so it could be omitted to make it consistent with other File::upload calls in our code.

Testing Instructions

• Use Joomla 5.3 nightly build
• Apply patch
• Try to install an extension

Or code review should be enough, too.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

I have tested this item ✅ successfully on 9c260f5

I have tested this successfully- installed and uninstalled a few Components (small to complex), as well as modules, and plugins.

Thanks @joomdonation!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45244.}

[krishnagandhicode]

I have tested this item ✅ successfully on 9c260f5

Thanks @joomdonation!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45244.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45244.}

[laoneo]

Thanks!