-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Enable support for multiple image extensions in Random Image module #45200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @seaoffate-net, Can you please test it. |
|
I like the idea behind it. As Joomla! 5.3 is in feature freeze mode, I move it to 5.4, so it can be tested there. |
shouldnt that be 6.0? When @HLeithner did the big rebase the other week all unmerged features were moved to 6 |
|
Rebased on 6.0 |
|
Hi @seaoffate-net, Can you please test it. |
|
I think this is a useful enhancement for Joomla and would improve flexibility for module users. |
|
Hi
I have tried the update just now installed v5.30 i removed all but one of
the jpegs in the dir and uploaded a png to the folder
1. images
<https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking#>
2. myimages
<https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking#>
3. walking
<https://www.seaoffate.net/administrator/index.php?option=com_media&path=local-images:/myimages/walking#>
so now i have just two images for the random picture to choose
from usedCoinSeaoffate512.png
and Dwarf_Walking-In_Woods_with_Dryads-1024.jpeg. if i refresh the page it
still only shows the jpeg. if i delete the jpeg it will not show the png.
ihave tried a few different .png files but they will not show. i have
deleted the .png and renamed a jpeg to jpg and on it's own it will not
display and not with others. i renamed the .jpg to jpeg and then it display.
This behaviour is not really a problem to me now that I know what it does
but I think it is not what is intended.so I alerted devs. please for my
part dont take any trouble to fix this as it is not a problem for me.
regards Nigel
…On Tue, Mar 25, 2025 at 4:55 PM Adarsh Santoria ***@***.***> wrote:
Hi @seaoffate-net <https://github.com/seaoffate-net>, Can you please test
it.
—
Reply to this email directly, view it on GitHub
<#45200 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQYWBDCUFEMBFBIXVQBRIML2WGDA3AVCNFSM6AAAAABZTOS5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJRHEZTCMBSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: AdarshSantoria]*AdarshSantoria* left a comment
(joomla/joomla-cms#45200)
<#45200 (comment)>
Hi @seaoffate-net <https://github.com/seaoffate-net>, Can you please test
it.
—
Reply to this email directly, view it on GitHub
<#45200 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQYWBDCUFEMBFBIXVQBRIML2WGDA3AVCNFSM6AAAAABZTOS5QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONJRHEZTCMBSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @seaoffate-net, is the issue related to my changes? If yes, can you please attach images directly as your link requires login. Moreover, I think this is a good feature enhancement to add. |
|
I have tested this item ✅ successfully on 170f8ee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200. |
|
@ceford Could you repeat your test for this PR? When you had tested it, it had conflicts from a previous rebase. I just want to be sure it still works. It has to be tested on 6.0, e.g. a 6.0 nightly or with the patched package created for this PR by Drone. Thanks in advance. |
|
I have tested this item ✅ successfully on e799d18 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200. |
|
I have tested this item ✅ successfully on e799d18 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45200. |
|
Thanks for the change @AdarshSantoria and thanks to @exlemor, @ceford for persistent testing. |
Pull Request for Issue #45196
Summary of Changes
This pull request enhances the
mod_random_imagemodule by allowing the use of multiple image file extensions in the Image Type parameter. Previously, the module only supported a single extension likejpg. With this change, users can input comma-separated values (e.g.,jpg,jpeg,png) to support multiple file types simultaneously.Testing Instructions
.jpg,.jpeg,.png, and.webp.jpg,jpeg,png, or even uppercase likePNG.Actual result BEFORE applying this Pull Request
Only images with the exact extension specified (e.g., only

jpg) were displayed.Entering multiple extensions resulted in "No images" being shown.
Expected result AFTER applying this Pull Request
The module correctly loads and displays images of any extension listed in the comma-separated input (e.g.,

jpg,jpeg,png).Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed