[5.3] Author column #45179
Merged
[5.3] Author column #45179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a check in the Author column to display the author name if the id is not 0 else to display the author as None I believe this check to be incorrect. When a user is deleted from the users table the created_by in the content table is untouched so the condition in the query is never passed. This PR changes the condition to check for the author_name and this way we can satisfy the condition and are able to display the author as None This PR does not fix the related problem in the authors filter where you can not filter by author None even though it is intended that you can. Signed-off-by: BrianTeeman <[email protected]>
|
I have tested this item ✅ successfully on 270ed2a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179. |
|
I have tested this item ✅ successfully on 270ed2a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45179. |
Contributor
|
Thx |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
There is a check in the Author column to display the author name if the id is not 0 else to display the author as None
I believe this check to be incorrect. When a user is deleted from the users table the created_by in the content table is untouched so the condition in the query is never passed.
This PR changes the condition to check for the author_name and this way we can satisfy the condition and are able to display the author as None
This PR does not fix the related problem in the authors filter where you can not filter by author None even though it is intended that you can.
This changes in this PR if accepted will need to be applied to all other components with the same condition
Testing Instructions
Create two users
Create articles with each user
Delete one of the users
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed