[5.3] Catch undefined cors options when saving global options#45103
Merged
bembelimen merged 3 commits intojoomla:5.3-devfrom Mar 14, 2025
Merged
[5.3] Catch undefined cors options when saving global options#45103bembelimen merged 3 commits intojoomla:5.3-devfrom
bembelimen merged 3 commits intojoomla:5.3-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on edf6bc8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103. |
Contributor
|
I have tested this item ✅ successfully on edf6bc8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45103. |
Contributor
|
Thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When saving an option on cli, then are undefined property warnings thrown on error reporting maximum. This happens only when Joomla is installed through cli with the
php installation/joomla.phpcommand.Testing Instructions
Execut
cli/joomla.php config:set debug=1on the console within the joomla root folder.Actual result BEFORE applying this Pull Request
The following four warnings are displayed:
Expected result AFTER applying this Pull Request
No warnings.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed