-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Replace dialog GIF loader with SVG loader #45097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on a868df9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097. |
Contributor
|
I have tested this item ✅ successfully on a868df9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097. |
|
Congratulations @krishnaGandhi11 on your first PR test - now you no longer need my help you are good to go on your own. :) |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45097. |
Contributor
Contributor
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44232 .
Summary of Changes
Alternative to #44232
Testing Instructions
Please follow #44232
Actual result BEFORE applying this Pull Request
Loader looks not very good
Expected result AFTER applying this Pull Request
Loader looks good
Link to documentations
Please select: