Skip to content

[5.3][cypress] PHP Warning: Undefined array key "menuordering" on patch com_menus#45092

Merged
laoneo merged 1 commit intojoomla:5.3-devfrom
alikon:undefined-menuordering
Mar 8, 2025
Merged

[5.3][cypress] PHP Warning: Undefined array key "menuordering" on patch com_menus#45092
laoneo merged 1 commit intojoomla:5.3-devfrom
alikon:undefined-menuordering

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Mar 8, 2025

Pull Request for Issue # .

Summary of Changes

set menuordering in PATCH

Testing Instructions

npx cypress run --spec '.\tests\System\integration\api\com_menus\SiteMenuItems.cy.js
npx cypress run --spec '.\tests\System\integration\api\com_menus\AdministratorMenuItems.cy.js

Actual result BEFORE applying this Pull Request

PHP Warning: Undefined array key "menuordering" in ..\administrator\components\com_menus\src\Model\ItemModel.php on line 1333 etc

Expected result AFTER applying this Pull Request

no more

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review March 8, 2025 08:53
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 1f884e3

Shows the importance of checking the php error_log otherwise the tests are almost meaningless


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45092.

@laoneo laoneo merged commit 1cec2ba into joomla:5.3-dev Mar 8, 2025
3 of 4 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 8, 2025

Thanks

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 8, 2025
@alikon alikon deleted the undefined-menuordering branch March 8, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants