Merged
Conversation
With joomla#44850 during Joomla installation the configuration parameter `force_ssl` is set to 2 (Force HTTP Entire Site). This prevents the Joomla System Tests from running with HTTP. And as the test shows it is not necessary for the Joomla System Tests. Even without explicit setting the parameter `force_ssl` the Joomla System Tests can be run over either HTTP or HTTPS.
Contributor
|
its pointless to run tests on http as NO real site will ever run on HTTP in 2025 moreover running on HTTP prevents several real tests from running correctly |
Member
|
It is ok to remove the restriction. Like that you are able to define only with the base url in the cypress config if the tests should run on http or https. It would even be better to actually create a test if this flag works the way it is expected. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With #44850 during Joomla installation the configuration parameter
force_sslis set to 2 (Force HTTP Entire Site). This prevents the Joomla System Tests from running on HTTP. And as the test shows it is not necessary for the Joomla System Tests. Even without explicit setting the parameterforce_sslthe Joomla System Tests can be run over either HTTP or HTTPS.Testing Instructions
Run Joomla System Tests once with HTTP and once with HTTPS by web server setup and configuring
baseUrlincypress.config.mjsaccordingly.Actual result BEFORE applying this Pull Request
install/Installation.cy.jsand API tests are workingadministrator/components/com_banners/Banner.cy.jsExpected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed