[5.3] Clean up com_templates StyleModel

[joomdonation]

Pull Request for Issue # .

Summary of Changes

This PR makes several clean up to com_templates StyleModel:

• Remove populateState method, it does not do anything different than the code in parent class, so the override is useless
• Improve getItem method. Instead of copying code from parent class, we just call the method from parent class to get item data, then add additional logic to it.
• Improve preprocessForm code, prevent potential warnings when saving item failure (in that case, $data is an array, so we could not treat it as an object like how we do in the code at the moment)

Testing Instructions

1. Use Joomla 5.3
2. Apply patch
3. Access to System -> Template Styles, edit a template style and make sure it is still working as expected

Actual result BEFORE applying this Pull Request

Works, but there is potential warning when saving item false (not easy to show it to you)

Expected result AFTER applying this Pull Request

Works, with less, cleaner code and no potential warnings.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[alikon]

I have tested this item ✅ successfully on 24d923d

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.}

[joomdonation]

Thanks @alikon

[muhme]

I have tested on fc4338fbe3 with only the System Tests. Before applying this PR there are PHP Warnings:

• api/com_templates/Site.cy.js

PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400
PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400

• and api/com_templates/Administrator.cy.js

PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 399
PHP Warning:  Attempt to read property "parent" on array in /var/www/html/administrator/components/com_templates/src/Model/StyleModel.php on line 400

✅ After applying this PR the two tests are passing successfully and without PHP warnings.

[joomdonation]

Thanks @muhme. This PR also modifies code in different methods inside the StyleModel class, beside System tests, we also need to do real test to make sure template style can still be updated without error.

[ghost]

@joomdonation Is it enough to modify a template style and save? Or mean the instructions another way saying "potential warning when saving item false (not easy to show it) (…) Works (…) no potential warnings".

[joomdonation]

Thanks @fgsw. Just edit template style, save it and make sure that it is still working like before (mean nothing is broken with updating a template style)

[ghost]

I have tested this item ✅ successfully on 043c7ad

Changed all colour fields settings, added an image to each image field.

• Result: Same behaviour as without pull request.
• Test by using custom update server.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.}

[joomdonation]

RTC. Thanks for testing!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45077.}

[laoneo]

Thanks!

[joomdonation]

Thanks everyone !