Skip to content

Comments

[5.3][cypress] Add tests for shortcut plugin#45061

Merged
laoneo merged 10 commits intojoomla:5.3-devfrom
heelc29:5.2/system-tests/shortcut
Mar 7, 2025
Merged

[5.3][cypress] Add tests for shortcut plugin#45061
laoneo merged 10 commits intojoomla:5.3-devfrom
heelc29:5.2/system-tests/shortcut

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Mar 2, 2025

Summary of Changes

test function of shortcut plugin

Testing Instructions

  • npx cypress run --spec '.\tests\System\integration\plugins\system\shortcut\ShortcutPlugin.cy.js'

Actual result BEFORE applying this Pull Request

not tested

Expected result AFTER applying this Pull Request

tested

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@heelc29 heelc29 force-pushed the 5.2/system-tests/shortcut branch from 69f66af to 21d890e Compare March 2, 2025 18:09
@alikon
Copy link
Contributor

alikon commented Mar 2, 2025

something left from #45059

@heelc29
Copy link
Contributor Author

heelc29 commented Mar 2, 2025

something left from #45059

Yes, otherwise ci fails
https://ci.joomla.org/joomla/joomla-cms/82835

@alikon
Copy link
Contributor

alikon commented Mar 2, 2025

ah ok , then better to test/merge #45059 first

@alikon
Copy link
Contributor

alikon commented Mar 2, 2025

now #45059 has been merged

@alikon
Copy link
Contributor

alikon commented Mar 2, 2025

i'll mark this tested successfully tested without the now unneeded 2 files from #45059

@alikon
Copy link
Contributor

alikon commented Mar 2, 2025

I have tested this item ✅ successfully on 21d890e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45061.

@laoneo
Copy link
Member

laoneo commented Mar 3, 2025

Can you rebase this pr to 5.3? Better to focus now on 5.3. Thanks...

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 21d890e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45061.

@heelc29 heelc29 changed the base branch from 5.2-dev to 5.3-dev March 3, 2025 16:45
@heelc29 heelc29 changed the title [5.2][cypress] Add tests for shortcut plugin [5.3][cypress] Add tests for shortcut plugin Mar 3, 2025
@brianteeman
Copy link
Contributor

please do not include unrelated files.

@heelc29
Copy link
Contributor Author

heelc29 commented Mar 3, 2025

please do not include unrelated files.

Missing upmerge from 5.2 to 5.3

@brianteeman
Copy link
Contributor

then you should put a note in the PR testing instructions about that. They should not be in this PR!!

@heelc29 heelc29 marked this pull request as draft March 3, 2025 17:33
@heelc29
Copy link
Contributor Author

heelc29 commented Mar 3, 2025

then you should put a note in the PR testing instructions about that. They should not be in this PR!!

Draft now

@laoneo
Copy link
Member

laoneo commented Mar 5, 2025

5.3 should have now the changes from #45059

@heelc29
Copy link
Contributor Author

heelc29 commented Mar 5, 2025

@laoneo Do I miss something ... I don't see an Upmerge form 5.2-dev to 5.3-dev
5.3-dev still missing 2 commits - including #45059
image

@laoneo
Copy link
Member

laoneo commented Mar 5, 2025

Ah sorry, then I missed it. Thought I saw it in my local repo.

@laoneo laoneo self-assigned this Mar 6, 2025
@laoneo laoneo removed the PR-5.2-dev label Mar 7, 2025
@laoneo laoneo marked this pull request as ready for review March 7, 2025 13:43
@laoneo laoneo merged commit 5fcd198 into joomla:5.3-dev Mar 7, 2025
3 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 7, 2025

Thanks!

@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 7, 2025
@heelc29 heelc29 deleted the 5.2/system-tests/shortcut branch May 4, 2025 07:23
@laoneo laoneo removed their assignment May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants