Skip to content

[5.3] Remove JPATH_COMPONENT_ADMINISTRATOR usage in components code#45049

Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom
joomdonation:remove_jpath_administrator_usage
Mar 8, 2025
Merged

[5.3] Remove JPATH_COMPONENT_ADMINISTRATOR usage in components code#45049
rdeutz merged 2 commits intojoomla:5.3-devfrom
joomdonation:remove_jpath_administrator_usage

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

The constant JPATH_COMPONENT_ADMINISTRATOR was deprecated long time ago because the path is coupled with the active component, thus prevent code re-usable.

This PR removes the usage of the constant in all components for site and admin apps. Basically, it will be replaced with JPATH_ADMINISTRATOR . '/components/com_componentname' where com_componentname is the name of component the code belong to

Testing Instructions

The change is made for different components, so we need to do code review for every single change and make sure it is correct.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, without used a deprecated constant and make code re-usable.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Mar 3, 2025

I have tested this item ✅ successfully on 7a33acf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45049.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 7a33acf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45049.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45049.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 4, 2025
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Mar 8, 2025
@rdeutz rdeutz merged commit 5bd9d00 into joomla:5.3-dev Mar 8, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 8, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Mar 8, 2025

Thanks

@joomdonation joomdonation deleted the remove_jpath_administrator_usage branch March 9, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants