Skip to content

[5.3] Remove un-used variables #45045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdeutz merged 2 commits into from
Mar 8, 2025
Merged

[5.3] Remove un-used variables #45045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
318ceb5
Remove un-used variables
joomdonation Mar 1, 2025
4d639ae
Merge branch '5.3-dev' into remove_unused_variables
rdeutz Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions administrator/components/com_config/src/Model/ApplicationModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,8 +786,6 @@ public function save($data)
*/
public function removeroot()
{
$app = Factory::getApplication();

// Get the previous configuration.
$prev = new \JConfig();
$prev = ArrayHelper::fromObject($prev);
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_messages/src/View/Messages/HtmlView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ public function display($tpl = null)
*/
protected function addToolbar()
{
$state = $this->state;
$canDo = ContentHelper::getActions('com_messages');
$user = $this->getCurrentUser();

Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_scheduler/src/View/Logs/HtmlView.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ public function display($tpl = null): void
protected function addToolbar(): void
{
$canDo = ContentHelper::getActions('com_scheduler');
$user = Factory::getApplication()->getIdentity();
$toolbar = Toolbar::getInstance();

ToolbarHelper::title(Text::_('COM_SCHEDULER_FIELDSET_EXEC_HIST'), 'list');
Expand Down
3 changes: 0 additions & 3 deletions administrator/components/com_templates/src/Model/TemplateModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,6 @@ public function getCoreList()
// Initialize the array variable to store core file list.
$this->coreFileList = [];

$app = Factory::getApplication();

foreach ($templates as $template) {
$client = ApplicationHelper::getClientInfo($template->client_id);
$element = Path::clean($client->path . '/templates/' . $template->element . '/');
Expand Down Expand Up @@ -473,7 +471,6 @@ public function getDirectoryTree($dir)
*/
public function getCoreFile($file, $client_id)
{
$app = Factory::getApplication();
$filePath = Path::clean($file);
$explodeArray = explode(DIRECTORY_SEPARATOR, $filePath);

Expand Down
2 changes: 0 additions & 2 deletions administrator/components/com_users/src/Controller/CallbackController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,6 @@ public function __construct(array $config = [], ?MVCFactoryInterface $factory =
*/
public function callback($cachable = false, $urlparams = false): void
{
$app = $this->app;

// Get the Method and make sure it's non-empty
$method = $this->input->getCmd('method', '');

Expand Down