Skip to content

[5.3][cypress] php warning#45030

Merged
laoneo merged 7 commits intojoomla:5.3-devfrom
alikon:patch-25
Mar 10, 2025
Merged

[5.3][cypress] php warning#45030
laoneo merged 7 commits intojoomla:5.3-devfrom
alikon:patch-25

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Feb 27, 2025

Pull Request for Issue #45007 .

Summary of Changes

check array key

Testing Instructions

run
npx cypress run --spec '.\tests\System\integration\api\com_users\Users.cy.js'

Actual result BEFORE applying this Pull Request

[24-Feb-2025 19:25:27 UTC] PHP Warning: Undefined array key "password2" in D:\repos\j51\administrator\components\com_users\src\Model\UserModel.php on line 295

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review February 28, 2025 08:40
@muhme
Copy link
Contributor

muhme commented Mar 1, 2025

✅ successful tested with JBT, before applying this PR on 5.2-dev

scripts/create 52
scripts/test 52 system api/com_users/Users.cy.js 

There are two PHP Warnings:

[Sat Mar 01 15:54:09.120420 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295
[Sat Mar 01 15:54:09.477295 2025] [php:warn] [pid 23:tid 23] [client 10.0.0.1:58812] PHP Warning:  Undefined array key "password2" in /var/www/html/administrator/components/com_users/src/Model/UserModel.php on line 295

Applying this PR and test again:

scripts/patch 52 joomla-cms-45030
scripts/test 52 system api/com_users/Users.cy.js 

The Cypress test runs now without PHP Warnings successfully 👍

@alikon alikon changed the base branch from 5.2-dev to 5.3-dev March 2, 2025 19:55
@alikon alikon changed the title [5.x][cypress] php warning [5.3][cypress] php warning Mar 2, 2025
@alikon alikon removed the PR-5.2-dev label Mar 2, 2025
@laoneo
Copy link
Member

laoneo commented Mar 7, 2025

@muhme can yo give this another test?

@laoneo
Copy link
Member

laoneo commented Mar 7, 2025

I have tested this item ✅ successfully on 9ea2c27

I'v logged in in a private browser window and in another one edited the user and set a new password. After save, the user got logged out in the private browser window. Did the same without setting a password, and he stayed logged in.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

@laoneo laoneo self-assigned this Mar 7, 2025
@muhme
Copy link
Contributor

muhme commented Mar 7, 2025

I have tested this item ✅ successfully on 9ea2c27

Cypress test api/com_users/Users.cy.js with JBT on current 5.3-dev: Before applying this PR there are two PHP warnings. After applaying this PR the Cypress test runs without PHP Warnings successfully. 👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 9ea2c27


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

@QuyTon
Copy link
Contributor

QuyTon commented Mar 10, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45030.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 10, 2025
@laoneo laoneo merged commit 7bd454b into joomla:5.3-dev Mar 10, 2025
3 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 10, 2025

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 10, 2025
@laoneo laoneo added this to the Joomla! 5.3.0 milestone Mar 10, 2025
@laoneo laoneo removed their assignment May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants