Skip to content

[5.3] Remove redundant entry in the npm tools#45027

Merged
rdeutz merged 1 commit intojoomla:5.3-devfrom
dgrammatiko:patch-1
Mar 9, 2025
Merged

[5.3] Remove redundant entry in the npm tools#45027
rdeutz merged 1 commit intojoomla:5.3-devfrom
dgrammatiko:patch-1

Conversation

@dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

  • In J5 codemirror was upgraded to v6 with it's own build script but there's an entry in the minification of the vendors pointing to the vendor/codemirror folder. This is redundant

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Fedik

@Fedik
Copy link
Member

Fedik commented Feb 27, 2025

I have tested this item ✅ successfully on f0d9bba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@Fedik Fedik added the bug label Feb 27, 2025
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f0d9bba

verified that it does nothing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@QuyTon QuyTon removed the bug label Feb 27, 2025
@QuyTon
Copy link
Contributor

QuyTon commented Feb 27, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45027.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 27, 2025
@QuyTon QuyTon added the bug label Feb 27, 2025
@laoneo laoneo changed the base branch from 5.2-dev to 5.3-dev March 9, 2025 09:22
@laoneo
Copy link
Member

laoneo commented Mar 9, 2025

I'v rebased it to 5.3. Can you fix the conflict please?

@laoneo laoneo changed the title [5.2] Remove redundant entry in the npm tools [5.3] Remove redundant entry in the npm tools Mar 9, 2025
@rdeutz rdeutz merged commit 2431acf into joomla:5.3-dev Mar 9, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 9, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Mar 9, 2025

Thanks

@dgrammatiko dgrammatiko deleted the patch-1 branch March 9, 2025 13:31
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants