[6.0] Field simple color as web component#45004
Conversation
|
When I try to test this PR from the Joomla_6.0.0-alpha1-dev+pr.45004-Development-Full_Package.zip file, I get this error when trying to go to Administrator Templates in the backend: An error has occurred. Function Location1 () JROOT/administrator/components/com_templates/tmpl/templates/default.php:101 Checked with Philip who verified I was doing it correctly. |
|
I have tested this item ✅ successfully on ff4b424 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45004. |
|
@softforge any interest here? |
I will check over the weekend and get back to you. |
|
@dgrammatiko I realise that @softforge never replied but there are merge conflicts now that need resolving |
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Quy <quy@nomonkeybiz.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
bdeb009 to
ab20d37
Compare
|
resolved the conflicts |
yes, I used the Download package: Joomla_6.0.0-alpha4-dev+pr.45004-Development-Update_Package.zip and was doing during the PR Testing Group session and Martina and others were there to watch me ;) |
|
I just tried it myself and it's fine. Can you post the contents of the file |
|
I have tested this item ✅ successfully on ab20d37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45004. |
|
I have tested this item ✅ successfully on ab20d37
Navigation works as described in the testing instructions. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45004. |
|
I have tested this item 🔴 unsuccessfully on ab20d37 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45004. @dgrammatiko here is the file you requested. joomla-field-simple-color.js.txt |
|
@exlemor do you have any errors in the browser console? |
No, NOTHING in the Console (no warning, no errors, etc). |
|
Could you post a gif/video of what’s happening there. I tested it also in sf18.6 and works fine |
|
@exlemor could you test it with debug on? |
|
Here is the video, its tough to show as you can't see the keys I am pressing on my keyboard but I promise I know where the Tab key is ;) ScreenFloat.Recording.of.Safari.at.Aug.15.2025.at.11_40_27.PM.mov |
Sure, I can try that. |
|
I can also open a Google Meet or equivalent and share my screen if you want. |
|
I found the issue/solution... There is an OS level option on Mac Sequoia 15.6 (and since 2022 and possibly before that version) Keyboard Navigation inline help says: Use keyboard navigation to move focus between controls. Press the Tab key to move focus forward Shift Tab to move the focus backwards. IF you turn that feature ON, then your code works, here is the rub though... the ISSUE is that it is NOT on by Default on Macs (I checked (and has never been defaulted to ON). |
|
So, @exlemor it was a safari setting the problem not my code! FWIW macOS has voiceOver for the accessibility and with that enabled (if I am not wrong) the keyboard functions as expected. Anyways, this PR is fine and does what it advertises |
|
This keyboard navigation setting is turned off on my mac and it still worked fine. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45004. |
|
@exlemor If your issue can be reproduced we have to fix it with another PR. For now we want to come forward with this one. |
|
Thank you for your work on this and all the dedicated testers |
Summary of Changes
Refactor the code so:
shadowRoot.adoptedStyleSheetsfor CSP strict css baseline 2023elementInternalsso it is an actual form field baseline 2023color(colorspace val1 val2 val3 / alpha)). This requires setting the format to"". All color values are validated client sideB/C considerations:
Testing Instructions
Paste this:
in the
templateDetails.xmlof the Atum template (after line 51:<fieldset name="colors" label="TPL_ATUM_COLORS_SETTINGS_LABEL">)Check that the field:
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Screen.Recording.2024-03-19.at.6.11.53.PM.mov
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Unused strings