[5.3] Display Mail Templates data use current language#44953
Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom Feb 22, 2025
Merged
Conversation
|
I couldn't test this issue because i am not able to install the languages for 5.3 version. Getting an unable to detect manifest file error This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953. |
Contributor
Author
|
@Pritams43 You can go to https://downloads.joomla.org/language-packs/translations-joomla5 , download language packages from there and install it manually |
|
I have tested this item ✅ successfully on ba18cf4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953. |
|
I have tested this item ✅ successfully on ba18cf4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953. |
Member
|
thanks |
|
I am able to test it now. Thanks @joomdonation This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953. |
Contributor
Author
|
Thanks @Pritams43 . The PR was merged, so no need for testing anymore. Please continue testing other open PRs. Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44879.
Summary of Changes
Currently, the Mail Templates management screen always use site default language to display mail template data (Title, Description...). This PR modifies code to display data using the current language instead, fix the issue #44879
Testing Instructions
See #44879, understand the issue. Apply path, confirm that the issue fixed.
Actual result BEFORE applying this Pull Request
Mail Templates always site default language for displaying data
Expected result AFTER applying this Pull Request
Mail Templates use current language to display data
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed