Skip to content

Comments

[5.3] Display Mail Templates data use current language#44953

Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:use_current_language_for_mail_templates
Feb 22, 2025
Merged

[5.3] Display Mail Templates data use current language#44953
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:use_current_language_for_mail_templates

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue #44879.

Summary of Changes

Currently, the Mail Templates management screen always use site default language to display mail template data (Title, Description...). This PR modifies code to display data using the current language instead, fix the issue #44879

Testing Instructions

See #44879, understand the issue. Apply path, confirm that the issue fixed.

Actual result BEFORE applying this Pull Request

Mail Templates always site default language for displaying data

Expected result AFTER applying this Pull Request

Mail Templates use current language to display data

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Pritams43
Copy link

I couldn't test this issue because i am not able to install the languages for 5.3 version. Getting an unable to detect manifest file error


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953.

@joomdonation
Copy link
Contributor Author

@Pritams43 You can go to https://downloads.joomla.org/language-packs/translations-joomla5 , download language packages from there and install it manually

@exlemor
Copy link

exlemor commented Feb 22, 2025

I have tested this item ✅ successfully on ba18cf4

I was able to test this successfully during PFB 2025.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953.

@crimle
Copy link

crimle commented Feb 22, 2025

I have tested this item ✅ successfully on ba18cf4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953.

@joomla-cms-bot joomla-cms-bot removed PBF Pizza, Bugs and Fun PR-5.3-dev labels Feb 22, 2025
@alikon
Copy link
Contributor

alikon commented Feb 22, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@alikon alikon added PBF Pizza, Bugs and Fun PR-5.3-dev labels Feb 22, 2025
@HLeithner HLeithner merged commit a654edf into joomla:5.3-dev Feb 22, 2025
4 checks passed
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@Pritams43
Copy link

I am able to test it now. Thanks @joomdonation


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44953.

@joomdonation
Copy link
Contributor Author

Thanks @Pritams43 . The PR was merged, so no need for testing anymore. Please continue testing other open PRs. Thanks !

@joomdonation joomdonation deleted the use_current_language_for_mail_templates branch February 22, 2025 15:45
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PBF Pizza, Bugs and Fun

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants