Skip to content

[5.3] Use str_contains function for libraries code#44917

Merged
HLeithner merged 3 commits intojoomla:5.3-devfrom
joomdonation:use_str_contains_for_libraries
Feb 22, 2025
Merged

[5.3] Use str_contains function for libraries code#44917
HLeithner merged 3 commits intojoomla:5.3-devfrom
joomdonation:use_str_contains_for_libraries

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR uses StrContainsRector rule to convert our libraries code to use str_contains function. It does not change any existing behavior, just make the code cleaner and easier to read. The change is done automatically by rector, no manual change included here.

Testing Instructions

Need to have code review for every single change here.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 16, 2025

I have tested this item ✅ successfully on 65f955d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917.

@mfleeson
Copy link
Contributor

Appears to be working correctly. Drone fails with phpstan complaining about code that's using deprecated features. Not sure I know enough to pass this but I think it tests okay.

@joomdonation
Copy link
Contributor Author

Thanks @mfleeson for looking at the PR. Could you mark your test result?

@tekvishal
Copy link

I have not tested this item.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917.

@ghost
Copy link

ghost commented Feb 22, 2025

I have not tested this item.

@tekvishal Maybe you have not marked your test result as "successfully" or "unsuccessfully"?

Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@HLeithner HLeithner merged commit 6c51496 into joomla:5.3-dev Feb 22, 2025
1 of 3 checks passed
@HLeithner
Copy link
Member

thanks

@joomdonation joomdonation deleted the use_str_contains_for_libraries branch February 22, 2025 15:55
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments