[5.3] Use str_contains function for libraries code#44917
Merged
HLeithner merged 3 commits intojoomla:5.3-devfrom Feb 22, 2025
Merged
[5.3] Use str_contains function for libraries code#44917HLeithner merged 3 commits intojoomla:5.3-devfrom
HLeithner merged 3 commits intojoomla:5.3-devfrom
Conversation
LadySolveig
approved these changes
Feb 16, 2025
Contributor
|
I have tested this item ✅ successfully on 65f955d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917. |
Contributor
|
Appears to be working correctly. Drone fails with phpstan complaining about code that's using deprecated features. Not sure I know enough to pass this but I think it tests okay. |
Contributor
Author
|
Thanks @mfleeson for looking at the PR. Could you mark your test result? |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44917. |
@tekvishal Maybe you have not marked your test result as "successfully" or "unsuccessfully"? |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This PR uses StrContainsRector rule to convert our libraries code to use str_contains function. It does not change any existing behavior, just make the code cleaner and easier to read. The change is done automatically by rector, no manual change included here.
Testing Instructions
Need to have code review for every single change here.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works, with cleaner, easier to read code.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed