Skip to content

Comments

[5.3] Use str_starts_with function for libraries code#44915

Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:str_starts_with_for_libraries
Feb 22, 2025
Merged

[5.3] Use str_starts_with function for libraries code#44915
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:str_starts_with_for_libraries

Conversation

@joomdonation
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

This PR uses StrStartsWithRector rule to convert our libraries code to use str_starts_with function. It does not change any existing behavior, just make the code cleaner and easier to read.

Testing Instructions

Need to have code review for every single change here.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner, easier to read code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 16, 2025

I have tested this item ✅ successfully on e72ca72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44915.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e72ca72


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44915.

@alikon
Copy link
Contributor

alikon commented Feb 17, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44915.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 17, 2025
Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@HLeithner HLeithner merged commit 733fb54 into joomla:5.3-dev Feb 22, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@HLeithner
Copy link
Member

thanks

@joomdonation
Copy link
Contributor Author

Thank you everyone !

@joomdonation joomdonation deleted the str_starts_with_for_libraries branch February 22, 2025 15:57
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants