[5.2][UnitTest] Use @backupGlobals to backup $_SERVER#44911
Merged
wilsonge merged 1 commit intojoomla:5.2-devfrom Feb 15, 2025
Merged
[5.2][UnitTest] Use @backupGlobals to backup $_SERVER#44911wilsonge merged 1 commit intojoomla:5.2-devfrom
wilsonge merged 1 commit intojoomla:5.2-devfrom
Conversation
Contributor
|
Thanks! As this is just tests, I'm merging on review with the tests passing. Additionally as just tests happy to merge this whilst we're in RC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Some tests need to backup the
$_SERVERsuper-global array before execution. To do this they save the$_SERVERto protected property. But PHPUnit for a long time supports a @backupGlobal annotation for these cases.Testing Instructions
Launch tests and ensure there are no errors:
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed