[5.3] [Installation][CLI] Fix hidden option asking

[voronkovich]

Summary of Changes

Install command hides input when asking for --db-pass and --admin-password values. But it also checks for an option --public_folder which is a typo.

Testing Instructions

1. Try to install Joomla using CLI:

   php installation/joomla.php install

2. Ensure that the public folder option appearing as the last question and its value is not hidden.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[dgrammatiko]

@voronkovich have you tested installing Joomla from CLI with the interactive version? Is the public folder appearing as the last question after this change?

[voronkovich]

@dgrammatiko, I've tested it right now. All works as expected.

[richard67]

Testing Instructions

I think testing is not needed.

No, sorry. For non trivial PRs which do not just change some comments or so, testing is ALWAYS required, and PR authors are expected to provide testing instructions.

[voronkovich]

@richard67, I've added testing instructions.

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.

[HLeithner]

I have tested this item ✅ successfully on d1307ab

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44908.}

[HLeithner]

thanks