Skip to content

Comments

[5.3] Remove unused variable store Exception in try catch block#44892

Merged
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:use-remove-unused-variable-in-catch-rector-rule
Feb 22, 2025
Merged

[5.3] Remove unused variable store Exception in try catch block#44892
HLeithner merged 1 commit intojoomla:5.3-devfrom
joomdonation:use-remove-unused-variable-in-catch-rector-rule

Conversation

@joomdonation
Copy link
Contributor

@joomdonation joomdonation commented Feb 13, 2025

Pull Request for Issue # .

Summary of Changes

This PR uses RemoveUnusedVariableInCatchRector rector rule to remove unused variable in try catch block in our components code. This is done automatically by rector, no manual change included.

Testing Instructions

Code review

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, with cleaner code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@QuyTon
Copy link
Contributor

QuyTon commented Feb 16, 2025

I have tested this item ✅ successfully on 7b35598


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44892.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7b35598


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44892.

@alikon
Copy link
Contributor

alikon commented Feb 17, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44892.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 17, 2025
Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@HLeithner HLeithner merged commit 28035af into joomla:5.3-dev Feb 22, 2025
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 22, 2025
@joomdonation
Copy link
Contributor Author

Thanks all for your help !

@joomdonation joomdonation deleted the use-remove-unused-variable-in-catch-rector-rule branch February 22, 2025 15:58
@QuyTon QuyTon added this to the Joomla! 5.3.0 milestone Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants