[5.3] Revert new option and db column from PR 44640 and always exclude current user from email notifications#44846
Closed
richard67 wants to merge 2 commits intojoomla:5.3-devfrom
Closed
Conversation
This was referenced Feb 9, 2025
Contributor
|
I prefer the second solution. It is as usual in many applications. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44827 - alternative 2 .
The other alternative would be PR #44845 .
Summary of Changes
This pull request (PR) reverts the action log system plugin's configuration option and the corresponding database column in the
#__action_logs_userstable, which were added with PR #44640 and released with 5.3.0-alpha3, and changes code so that the current user is always excluded from email notifications.The code could possibly be improved so that certain kinds of actions would not be excluded.
Testing Instructions
Will be added sooner or later.
Actual result BEFORE applying this Pull Request
Will be added sooner or later.
Expected result AFTER applying this Pull Request
Will be added sooner or later.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed