Skip to content

[5.3] Revert new option and db column from PR 44640 and always exclude current user from email notifications#44846

Closed
richard67 wants to merge 2 commits intojoomla:5.3-devfrom
richard67:5.3-dev-pr-44640-modify-1
Closed

[5.3] Revert new option and db column from PR 44640 and always exclude current user from email notifications#44846
richard67 wants to merge 2 commits intojoomla:5.3-devfrom
richard67:5.3-dev-pr-44640-modify-1

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Feb 9, 2025

Pull Request for Issue #44827 - alternative 2 .

The other alternative would be PR #44845 .

Summary of Changes

This pull request (PR) reverts the action log system plugin's configuration option and the corresponding database column in the #__action_logs_users table, which were added with PR #44640 and released with 5.3.0-alpha3, and changes code so that the current user is always excluded from email notifications.

The code could possibly be improved so that certain kinds of actions would not be excluded.

Testing Instructions

Will be added sooner or later.

Actual result BEFORE applying this Pull Request

Will be added sooner or later.

Expected result AFTER applying this Pull Request

Will be added sooner or later.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Feb 9, 2025
@richard67 richard67 changed the title [5.3] Revert new option and db column from PR #44640 and always exclude current user from email notifications [5.3] Revert new option and db column from PR 44640 and always exclude current user from email notifications Feb 9, 2025
@chmst
Copy link
Contributor

chmst commented Feb 11, 2025

I prefer the second solution. It is as usual in many applications.

@richard67
Copy link
Member Author

We have discussed the issue and my 2 alternatives in the CMS Maintenance Team's weekly meeting and decided to use my other PR to completely revert PR #44640 before 5.3.0-beta1. Then we have all the time to work on a better solution.

Closing in favour of #44845 .

@richard67 richard67 closed this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants