[5.3] Fix the selector in login tests when running on https#44837
Merged
laoneo merged 2 commits intojoomla:5.3-devfrom Feb 7, 2025
Merged
[5.3] Fix the selector in login tests when running on https#44837laoneo merged 2 commits intojoomla:5.3-devfrom
laoneo merged 2 commits intojoomla:5.3-devfrom
Conversation
None of the login tests were working as they had only been tested on http When tested in a real work with https the webauthn plugin is also present and the tests all failed This PR updates the cypress get identifier to more accurately target the login button Signed-off-by: BrianTeeman <brian@teeman.net>
Member
|
Thanks. As soon as we are green here, it will be merged. Despite the fix, you discovered a bigger issue and we should change our tests to https, as in #44835, as this is nowadays the standard. |
Contributor
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
None of the login tests were working as they had only been tested on http When tested in a real work with https the webauthn plugin is also present and the tests all failed
This PR updates the cypress get identifier to more accurately target the login button
Testing Instructions
run the cypress tests with https
Actual result BEFORE applying this Pull Request
tests fail with error message
CypressError:cy.click()can only be called on a single element. Your subject contained 2 elements. Pass{ multiple: true }if you want to serially click each element.Expected result AFTER applying this Pull Request
tests complete successfully
Note
This does not resolve the fact that the cypress tests should be running under https otherwise they are incomplete or risky tests
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed