[5.3] onContentPrepareForm should return void instead of boolean#44817
Merged
laoneo merged 1 commit intojoomla:5.3-devfrom Feb 4, 2025
Merged
Conversation
Member
|
Thank you! |
Contributor
Author
|
Thanks @laoneo for the quick merge ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
While review code of the already merged PR #43426, I found a small issue with the code. The
onContentPrepareFormmethod ofConfirmConsentclass should not return boolean value, it should return void instead, like in the System - Fields plugin code https://github.com/joomla/joomla-cms/blob/5.3-dev/plugins/system/fields/src/Extension/Fields.php#L247In general, when converting our plugins to use
SubscriberInterface, the event listeners should always return void. If we need to pass result back, use $event->addResultmethod instead of return commandTesting Instructions
Code review should be enough
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed