[5.3] Switching voku/portable-utf8 to own fork#44810
Closed
Hackwar wants to merge 1 commit intojoomla:5.3-devfrom
Closed
[5.3] Switching voku/portable-utf8 to own fork#44810Hackwar wants to merge 1 commit intojoomla:5.3-devfrom
Hackwar wants to merge 1 commit intojoomla:5.3-devfrom
Conversation
Contributor
Member
|
Closing this in favor of #44489. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The voku/portable-utf8 package unfortunately seems to not be maintained anymore and especially in PHP 8.4 throws massive notices. Unfortunately we adopted it as a direct dependency to fix another issue with it in the past and are now stuck with it for compatibility reasons until the end of 5.x. #44654 removes it entirely for Joomla 6. To fix the PHP 8.4 issues, we forked the repo and added those fixes there. We are not going to maintain that repo.
Testing Instructions
composer iActual result BEFORE applying this Pull Request
Lots of PHP notices, among them issues relating to voku/portable-utf8
Expected result AFTER applying this Pull Request
The notices for voku/portable-utf8 are gone.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Documentation for deprecation and removal of voku/portable-utf8 Manual#381
No documentation changes for manual.joomla.org needed