Closed
Conversation
Member
|
I'm not in favor doing this (or anyting else) with the htmlhelper, it's a thing that should be removed and directly done in the webassetmanager or document it self. Didn't looked at the svg implementation it self, will do that later, at least it would be cool to have this if it's working. |
Contributor
Author
|
Could move it to the Document class or WAM. Fwiw first or second try was on the document class anyways this is implementation details could move the code around |
Contributor
Author
|
I'll close it for now. If I get some spare time I'll have another look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3rd try for inline SVG icons.
This is ONLY for demo purposes, if it gets a consensus there would be be a proper PR
Prior work:
Summary of Changes
[ name => svgCode ]) with all the FA iconsScope
Testing Instructions
I Just covered few icons so that it's easy for any reviewers to check what is happening.
The icon part could be done with a Layout for even easier usage.
I picked the show/hide password to showcase the JS changes (supports both font/inline svg icons)
Actual result BEFORE applying this Pull Request
Login

Cpanel

Expected result AFTER applying this Pull Request
Login

Cpanel

Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@laoneo @HLeithner @bembelimen @SniperSister @rdeutz