Skip to content

[6.0] Removing CMSObject from most of the codebase#44655

Merged
Bodge-IT merged 21 commits intojoomla:6.0-devfrom
Hackwar:6.0-cmsobject-1
Feb 5, 2025
Merged

[6.0] Removing CMSObject from most of the codebase#44655
Bodge-IT merged 21 commits intojoomla:6.0-devfrom
Hackwar:6.0-cmsobject-1

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Dec 21, 2024

Summary of Changes

This PR removes CMSObject from a lot of cases in our codebase. The last parts where this is left is the media manager, a few classes and com_finder. For com_finder there is another PR (#43795).

Testing Instructions

Codereview?

Link to documentations

Please select:

@Hackwar Hackwar added the b/c break This item changes the behavior in an incompatible why. HEADS UP label Dec 22, 2024
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
@Bodge-IT Bodge-IT added this to the Joomla! 6.0.0 milestone Feb 3, 2025
Hackwar and others added 3 commits February 5, 2025 08:39
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
@Bodge-IT Bodge-IT merged commit 46be0b6 into joomla:6.0-dev Feb 5, 2025
3 checks passed
@Hackwar Hackwar deleted the 6.0-cmsobject-1 branch February 5, 2025 21:51
@QuyTon
Copy link
Contributor

QuyTon commented Feb 5, 2025

Maybe related to this PR. Go to System > Site Templates.

An error has occurred.
0 Call to undefined method stdClass::get()
Call Stack
#	Function	Location
1	()	JROOT\administrator\components\com_templates\tmpl\templates\default.php:101
2	include()	JROOT\libraries\src\MVC\View\HtmlView.php:416
3	Joomla\CMS\MVC\View\HtmlView->loadTemplate()	JROOT\libraries\src\MVC\View\HtmlView.php:204
4	Joomla\CMS\MVC\View\HtmlView->display()	JROOT\administrator\components\com_templates\src\View\Templates\HtmlView.php:128
5	Joomla\Component\Templates\Administrator\View\Templates\HtmlView->display()	JROOT\libraries\src\MVC\Controller\BaseController.php:697
6	Joomla\CMS\MVC\Controller\BaseController->display()	JROOT\administrator\components\com_templates\src\Controller\DisplayController.php:68
7	Joomla\Component\Templates\Administrator\Controller\DisplayController->display()	JROOT\libraries\src\MVC\Controller\BaseController.php:730
8	Joomla\CMS\MVC\Controller\BaseController->execute()	JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:143
9	Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch()	JROOT\libraries\src\Component\ComponentHelper.php:361
10	Joomla\CMS\Component\ComponentHelper::renderComponent()	JROOT\libraries\src\Application\AdministratorApplication.php:150
11	Joomla\CMS\Application\AdministratorApplication->dispatch()	JROOT\libraries\src\Application\AdministratorApplication.php:205
12	Joomla\CMS\Application\AdministratorApplication->doExecute()	JROOT\libraries\src\Application\CMSApplication.php:306
13	Joomla\CMS\Application\CMSApplication->execute()	JROOT\administrator\includes\app.php:58
14	require_once()	JROOT\administrator\index.php:32

@laoneo
Copy link
Member

laoneo commented Feb 6, 2025

Can you open an issue or event better a pr to fix it?

@richard67
Copy link
Member

That could be fixed with PR #45199 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b/c break This item changes the behavior in an incompatible why. HEADS UP PR-6.0-dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants