[5.3] System template offline RTL#44615
Merged
rdeutz merged 1 commit intojoomla:5.3-devfrom Jan 7, 2025
Merged
Conversation
By using logical css properties and removing unused css we can remove the system-site-offline RTL css file. One less file to maintain! Signed-off-by: BrianTeeman <brian@teeman.net>
joomla-cms-bot
added
NPM Resource Changed
|
I have tested this item ✅ successfully on 8d85c87
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44615. |
Contributor
|
setting RTC cause it was successfully tested by @Quy too |
joomla-cms-bot
removed
NPM Resource Changed
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44615. |
alikon
added
NPM Resource Changed
Contributor
|
Thanks |
richard67
added a commit
to richard67/joomla-cms
that referenced
this pull request
Jan 10, 2025
4 tasks
bembelimen
pushed a commit
that referenced
this pull request
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
By using logical css properties and removing unused css we can remove the system-site-offline RTL css file. One less file to maintain!
Testing Instructions
Set site to offline in global configuration
Set site language to an RTL language such as persian
Rename the cassiopeia offline.php so that we are using the fallback system template's offline.php
As this involves removing a css file and rebuilding an scss file either use a prebuilt package or do a full
npm ciActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
No visible change
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed