[5.3] Template Override Plugins Compare#44588
Merged
HLeithner merged 3 commits intojoomla:5.3-devfrom Dec 8, 2024
Merged
Conversation
Signed-off-by: BrianTeeman <brian@teeman.net>
|
I have tested this item ✅ successfully on ab53b22 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588. |
sandewt
reviewed
Dec 7, 2024
sandewt
reviewed
Dec 7, 2024
administrator/components/com_templates/src/Model/TemplateModel.php
Outdated
Show resolved
Hide resolved
Member
|
I've restored @fgsw 's test result in the issue tracker and have set the test result for @Quy as he can't do that currently so asked in Mattermost to do that. => RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44588. |
Member
|
slightly related is the wrong type usage for array access |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Adds override compare functionality to plugin overrides
Testing Instructions
In the template manager create an override for any plugin
Select one of the files in the override
Actual result BEFORE applying this Pull Request
Show Original File and Show Differences not present
Expected result AFTER applying this Pull Request
Show Original File and Show Differences are present and you can se the differences etc
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed