Skip to content

Refresh changelog URL on manifest cache refresh #44565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pe7er merged 2 commits into from
Dec 21, 2024
Merged

Refresh changelog URL on manifest cache refresh #44565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18f33b8
refresh changelog
AlterBrains Dec 2, 2024
18104ec
Merge branch '5.2-dev' into 5.2-refresh-changelogurl
pe7er Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libraries/src/Installer/Adapter/ComponentAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,7 @@ public function refreshManifestCache()
$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

// Namespace is optional
if (isset($manifest_details['namespace'])) {
Expand Down
1 change: 1 addition & 0 deletions libraries/src/Installer/Adapter/FileAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,7 @@ public function refreshManifestCache()
$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

try {
return $this->parent->extension->store();
Expand Down
2 changes: 2 additions & 0 deletions libraries/src/Installer/Adapter/LanguageAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,9 +734,11 @@ public function refreshManifestCache()

$this->parent->manifest = $this->parent->isManifest($manifestPath);
$this->parent->setPath('manifest', $manifestPath);

$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

if ($this->parent->extension->store()) {
return true;
Expand Down
1 change: 1 addition & 0 deletions libraries/src/Installer/Adapter/LibraryAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ public function refreshManifestCache()
$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

try {
return $this->parent->extension->store();
Expand Down
2 changes: 2 additions & 0 deletions libraries/src/Installer/Adapter/ModuleAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,11 @@ public function refreshManifestCache()
$manifestPath = $client->path . '/modules/' . $this->parent->extension->element . '/' . $this->parent->extension->element . '.xml';
$this->parent->manifest = $this->parent->isManifest($manifestPath);
$this->parent->setPath('manifest', $manifestPath);

$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

if ($this->parent->extension->store()) {
return true;
Expand Down
1 change: 1 addition & 0 deletions libraries/src/Installer/Adapter/PackageAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,7 @@ public function refreshManifestCache()
$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

try {
return $this->parent->extension->store();
Expand Down
5 changes: 3 additions & 2 deletions libraries/src/Installer/Adapter/PluginAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,10 +611,11 @@ public function refreshManifestCache()
. $this->parent->extension->element . '.xml';
$this->parent->manifest = $this->parent->isManifest($manifestPath);
$this->parent->setPath('manifest', $manifestPath);

$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);

$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

if ($this->parent->extension->store()) {
return true;
Expand Down
1 change: 1 addition & 0 deletions libraries/src/Installer/Adapter/TemplateAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ public function refreshManifestCache()
$manifest_details = Installer::parseXMLInstallFile($this->parent->getPath('manifest'));
$this->parent->extension->manifest_cache = json_encode($manifest_details);
$this->parent->extension->name = $manifest_details['name'];
$this->parent->extension->changelogurl = $manifest_details['changelogurl'];

try {
return $this->parent->extension->store();
Expand Down
13 changes: 7 additions & 6 deletions libraries/src/Installer/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,12 +2311,13 @@ public static function parseXMLInstallFile($path)
$data['creationDate'] = ((string) $xml->creationDate) ?: Text::_('JLIB_UNKNOWN');
$data['author'] = ((string) $xml->author) ?: Text::_('JLIB_UNKNOWN');

$data['copyright'] = (string) $xml->copyright;
$data['authorEmail'] = (string) $xml->authorEmail;
$data['authorUrl'] = (string) $xml->authorUrl;
$data['version'] = (string) $xml->version;
$data['description'] = (string) $xml->description;
$data['group'] = (string) $xml->group;
$data['copyright'] = (string) $xml->copyright;
$data['authorEmail'] = (string) $xml->authorEmail;
$data['authorUrl'] = (string) $xml->authorUrl;
$data['version'] = (string) $xml->version;
$data['description'] = (string) $xml->description;
$data['group'] = (string) $xml->group;
$data['changelogurl'] = (string) $xml->changelogurl;

// Child template specific fields.
if (isset($xml->inheritable)) {
Expand Down