Skip to content

[5.2] Plugins: Search not case-insensitive for unicode language#44525

Merged
pe7er merged 1 commit intojoomla:5.2-devfrom
Hackwar:5.2-plugins-search
Dec 2, 2024
Merged

[5.2] Plugins: Search not case-insensitive for unicode language#44525
pe7er merged 1 commit intojoomla:5.2-devfrom
Hackwar:5.2-plugins-search

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Nov 26, 2024

Pull Request for Issue #36300.

Summary of Changes

The search in the plugin list in the backend is not happening on the database level, but in PHP, since the names of the plugins are translated on the fly. The search in PHP is using the i modifier, which should make it case-insensitive, but without u this is still not searching for unicode characters and thus doesn't know if a unicode string is uppercase or not.

Testing Instructions

  1. Install the russian language in the Joomla site
  2. Set the default language for the backend to russian
  3. Go to the plugin manager and search for пользователь

Actual result BEFORE applying this Pull Request

The result list is empty.

Expected result AFTER applying this Pull Request

The result list displays several entries.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ghost
Copy link

ghost commented Nov 26, 2024

I have tested this item ✅ successfully on 8f7638c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 8f7638c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525.

@Hackwar
Copy link
Member Author

Hackwar commented Nov 26, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2024
@pe7er pe7er self-assigned this Nov 28, 2024
@pe7er pe7er merged commit edc24bb into joomla:5.2-dev Dec 2, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 2, 2024
@pe7er
Copy link
Contributor

pe7er commented Dec 2, 2024

Thanks @Hackwar !

@Hackwar Hackwar deleted the 5.2-plugins-search branch December 2, 2024 09:34
@Hackwar Hackwar added this to the Joomla! 5.2.3 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants