[5.2] Plugins: Search not case-insensitive for unicode language#44525
Merged
pe7er merged 1 commit intojoomla:5.2-devfrom Dec 2, 2024
Merged
[5.2] Plugins: Search not case-insensitive for unicode language#44525pe7er merged 1 commit intojoomla:5.2-devfrom
pe7er merged 1 commit intojoomla:5.2-devfrom
Conversation
|
I have tested this item ✅ successfully on 8f7638c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 8f7638c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525. |
Member
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44525. |
Contributor
|
Thanks @Hackwar ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #36300.
Summary of Changes
The search in the plugin list in the backend is not happening on the database level, but in PHP, since the names of the plugins are translated on the fly. The search in PHP is using the
imodifier, which should make it case-insensitive, but withoututhis is still not searching for unicode characters and thus doesn't know if a unicode string is uppercase or not.Testing Instructions
пользовательActual result BEFORE applying this Pull Request
The result list is empty.
Expected result AFTER applying this Pull Request
The result list displays several entries.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed