[6.0] Remove fixFilesystemPermissions method from script.php

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) removes the "fixFilesystemPermissions" method and its usage from file administrator/components/com_admin/script.php.

The method was added with PR #44379 to fix broken file and folder permissions when updating from Joomla 5.2.0 or 5.2.1 to a later 5.x version and was immediately deprecated for removal in 6.0, see the @todo comments for the removed code.

If you check the code of that method you will see that it only does something when updating from 5.2.0 or 5.2.1 to a later version. But updating to 6.0 will require to be on the latest 5.x, which currently is 5.3 and later will be 5.4, so when updating to 6 that method will never run and so it is useless in the 6.0-dev branch.

That's why it was marked to be removed in 6.0.

Testing Instructions

Code review, or if you want to do a real test:

Update a recent 5.3-dev nightly build to the latest 6.0-dev nightly build to get the actual result, and update a recent 5.3-dev nightly build to the patched package created by Drone for this PR to get the expected result.

The latest 5.3-dev nightly build can be found here: https://developer.joomla.org/nightlies/Joomla_5.3.0-alpha1-dev-Development-Full_Package.zip

The latest 6.0-dev nightly build update package can be found here: https://developer.joomla.org/nightlies/Joomla_6.0.0-alpha1-dev-Development-Update_Package.zip

The patched package created by Drone can be found here: https://artifacts.joomla.org/drone/joomla/joomla-cms/6.0-dev/44513/downloads/80514/Joomla_6.0.0-alpha1-dev+pr.44513-Development-Update_Package.zip

Actual result BEFORE applying this Pull Request

The update succeeds. The "fixFilesystemPermissions" method and a call to that function is still present in file administrator/components/com_admin/script.php.

Expected result AFTER applying this Pull Request

The update succeeds. The "fixFilesystemPermissions" method and the call to that function are not present in file administrator/components/com_admin/script.php.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ghost]

I have tested this item ✅ successfully on e8fb75a

Test by real test.

• Update latest 5.3-dev nightly build > latest 6.0-dev nightly build show unchanged script.php.
• Update latest 5.3-dev nightly build > Joomla_6.0.0-alpha1-dev+pr.44513-Development-Update_Package.zip show changed script.php.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44513.}

[Quy]

I have tested this item ✅ successfully on e8fb75a

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44513.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44513.}

[Bodge-IT]

Thank you @richard67 and for the testers.