-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[6.0] Searchtools use requestSubmit() and add joomla:update listener #44496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[6.0] Searchtools use requestSubmit() and add joomla:update listener #44496
Conversation
|
I would appreciate your feedback on whether this change makes sense to you. 🙂 @dgrammatiko @Fedik |
|
Seems makes sense. |
|
Thanks for the suggestion, will add the additional check tomorrow. 👍🏼 |
|
This pull request has been automatically rebased to 6.0-dev. |
|
I have tested this item ✅ successfully on 81bc1a2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44496. |
|
Thank you @LadySolveig for this improvement and @Fedik for your chat and testing yesterday, nice to catch up with you |
Pull Request for Issue # .
Summary of Changes
This PR replaces submit() with requestSubmit() method to make it possible to work with the submit event in other places after submission of the searchtool filters. (e. g. submit form and only partly reload page via ajax).
You can find more information here https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit#usage_notes
It also adds a joomla:updated event event listener for this use case to reinitialize functionality after only partly reloading the page.
Testing Instructions
Preparation
Add this code snippet at the bottom of your backend template javascript file.
e. g.
media/templates/administrator/atum/js/template.jsActivate debug mode in backend.
(Optional) Load sampledata via sample data plugin to have items to search and filter :)
Open articles listview in backend and open your browser dev tools.
Test filter, search and order functionality

After testing and checking the result before applying this PR
Fetch the pr and run
npm ciReAdd code snippet to your backend template.
Test filter, search and order functionality as before and check again the console log.
Additional check filter and search functionality in other listviews to make sure all works as before.
Actual result BEFORE applying this Pull Request
Nothing should be shown in your browser developement console log.
Expected result AFTER applying this Pull Request
You should see something like this in your browser developement console log.

[Important] Search and filter should work as before!
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed