[6.0] Fulfill InstallerScriptInterface with a trait#44381
[6.0] Fulfill InstallerScriptInterface with a trait#44381softforge merged 20 commits intojoomla:6.0-devfrom
Conversation
|
In general I'm not sure if the trait is the right approach. I would prefer a base class. |
|
What's the value of deprecating and forcing people to move. I mean I'm not fussed whether we use a base class or a trait to be honest - but I don't see the value of just deprecating and moving to the other one forcing code changes for next to no benefit. |
|
I miss an interface for this trait and I would replace the string type with an enum. I think the goal is to get type safety with out b/c break. |
|
The interface exists already, but I couldn't change the InstallerClass without braking bc at the time I made it. |
|
This pull request has been automatically rebased to 6.0-dev. |
HLeithner
left a comment
There was a problem hiding this comment.
I made some annotations maybe can comment on them.
Co-authored-by: Harald Leithner <leithner@itronic.at>
|
Shouldn't there be the option to set dB requirements |
Co-authored-by: Brian Teeman <brian@teeman.net>
It's not in the original, but it would be a nice improvement |
|
Thank you for the work on this, and for the testers adn reviewers who pointed out some improvements that can be made |
Summary of Changes
This implements a trait to be used in combination with the InstallerScriptInterface
Testing Instructions
I have no real idea, how to test it. You need an Extension using a install script with the InstallerScriptInterface. Using this trait should resolve the interface and give you some additional options like:
you can set
There are also two "custom" methods to extend preflight/postflight and still benefit from their functionality.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: Add new InstallerScriptTrait (PR #44381) Manual#448
No documentation changes for manual.joomla.org needed