URL in email broken with Mail Template Layout#44378
Merged
HLeithner merged 1 commit intojoomla:5.2-devfrom Oct 31, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 32525d9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 32525d9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44378. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44377 .
Summary of Changes
Move convertRelativeToAbsoluteUrls after replaceTags
Testing Instructions
Mail template com_users.password_reset, HTML Body:
Go frontent.
Forgot your password?
Check email Joomla sent you.
Actual result BEFORE applying this Pull Request
URL in email is broken:
https://www.mysite.com/https://www.mysite.com/component/users/reset.html?layout=confirm&token=blablabla&Itemid=123The
https://www.mysite.comis dobled in email.Expected result AFTER applying this Pull Request
URL in email is correct:
https://www.mysite.com/component/users/reset.html?layout=confirm&token=blablabla&Itemid=123No dobled
https://www.mysite.comin email.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed