Skip to content

[5.2] mod_submenu php fixes#44320

Merged
Hackwar merged 9 commits intojoomla:5.2-devfrom
peter1szalatnay:patch-1
Nov 13, 2024
Merged

[5.2] mod_submenu php fixes#44320
Hackwar merged 9 commits intojoomla:5.2-devfrom
peter1szalatnay:patch-1

Conversation

@peter1szalatnay
Copy link
Contributor

Summary of Changes

Fix an issues where xdebug always stop because asset is always missing from list, and it is just better then having @ for error handling.

Testing Instructions

Enable xdebug and go to the system page.

Actual result BEFORE applying this Pull Request

Exception has occurred.
Warning: Undefined array key 1

Expected result AFTER applying this Pull Request

No errors

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Fix an issues where xdebug always stop because asset is always missing from list, and it is just better then having @ for error handling.
Co-authored-by: Quy <quy@nomonkeybiz.com>
@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

I have tested this item ✅ successfully on 2d2ddbc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44320.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 2d2ddbc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44320.

@Quy
Copy link
Contributor

Quy commented Nov 1, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44320.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@pe7er pe7er self-assigned this Nov 11, 2024
@Hackwar Hackwar enabled auto-merge (squash) November 13, 2024 14:59
@Hackwar Hackwar merged commit cb0c4c8 into joomla:5.2-dev Nov 13, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 13, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.2 milestone Nov 13, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 13, 2024

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants