[5.2] No menu must be selected for menu items batch processing#44286
Merged
pe7er merged 5 commits intojoomla:5.2-devfrom Oct 20, 2024
Merged
[5.2] No menu must be selected for menu items batch processing#44286pe7er merged 5 commits intojoomla:5.2-devfrom
pe7er merged 5 commits intojoomla:5.2-devfrom
Conversation
4 tasks
Contributor
|
I have tested this item ✅ successfully on 9747667 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44286. |
1 similar comment
|
I have tested this item ✅ successfully on 9747667 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44286. |
Quy
reviewed
Oct 17, 2024
administrator/components/com_menus/tmpl/items/default_batch_body.php
Outdated
Show resolved
Hide resolved
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44286. |
Contributor
|
Thanks @chmst ! |
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Nov 27, 2024
joomla/joomla-cms#44139 + joomla/joomla-cms#44286 + joomla/joomla-cms#44166 + joomla/joomla-cms#43321 + joomla/joomla-cms#44266 - (только для др. пакетов) joomla/joomla-cms#44452 - (только для др. пакетов) + испр. ошибки #118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43215 #43214
Summary of Changes
Batch processing of menu items seems to be possible for all menu items, also if no menu is selected.
This PR removes the condition, that a menu must be selcted.
Testing Instructions
The more menus you have and the more options like multilingual, many leveles in the menus, the better.
Mark some menuItems - if you want select different levels, different languages,
Activate the batch processing in the actions menu.
Change language, access level,
copy or move the selecten menutems.
Make sure that
Actual result BEFORE applying this Pull Request
If no menu is selected, a message is displayed
COM_MENUS_SELECT_MENU_FIRST="To use batch processing, please first select a Menu in the manager."
Expected result AFTER applying this Pull Request
The batch processing is possible, also if no menu is selcted.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed