Skip to content

[6.0] New article from frontend send mail with Mailtemplate#44243

Closed
alikon wants to merge 17 commits intojoomla:6.0-devfrom
alikon:newarticle-mailtemplate
Closed

[6.0] New article from frontend send mail with Mailtemplate#44243
alikon wants to merge 17 commits intojoomla:6.0-devfrom
alikon:newarticle-mailtemplate

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Oct 13, 2024

Pull Request for Issue #43872 .

Summary of Changes

use the mail template instead of com_messages

Testing Instructions

apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package
send an article from frontend and check the email

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

the email is configurable with Mailtemplates

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Oct 13, 2024
alikon and others added 2 commits October 13, 2024 12:35
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@alikon alikon marked this pull request as ready for review October 14, 2024 09:50
@alikon alikon changed the title [wip] Newarticle2mailtemplate [5.3] New article from frontend send mail with Mailtemplate Oct 14, 2024
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on db74a7f

Before PR: article creation ---> email notification that there is a personal message. In the personal message in the panel there is information about a new article that was created by this and that.

After PR: article creation ---> email notification that such and such an article was created, written by that and that.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.

@komalm
Copy link

komalm commented Feb 22, 2025

I have tested this item 🔴 unsuccessfully on 014ac4e

Tested on: Joomla! 5.3-dev
Patch Applied Using: Joomla! Patch Tester

Steps Followed for Testing:

  • Applied the patch via Patch Tester.
  • Verified that mail settings are correctly configured.
  • Submitted a new article from the frontend.
  • Checked the email inbox for notifications.

Issue Observed:

@crommie
Copy link

crommie commented Feb 22, 2025

I have tested this item 🔴 unsuccessfully on 014ac4e

Tested on: Joomla! 5.3-dev on the test server
Patch Applied Using: Joomla! Patch Tester

Before: email was sent with mail template
After: email was sent with mail template


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243.

@alikon
Copy link
Contributor Author

alikon commented Feb 22, 2025

thanks for testing and for feedback
it was working in October 24 😄

i'll re-check and i'll make it after available for test again

@alikon alikon marked this pull request as draft February 22, 2025 09:15
@richard67
Copy link
Member

richard67 commented Feb 22, 2025

@alikon You have to rename the update SQL scripts to something newer than the newest in the branch, which is 5.3.0-2025-02-09.sql, so rename to e.g. 5.3.0-2025-02-22.sql. That'S the reason why your update SQL does not run when people update with the patched package from Drone.

And the PR has a conflict which needs to be resolved. If necessary I can help, but not before tonight.

@richard67
Copy link
Member

richard67 commented Feb 22, 2025

@komalm @crommie As this PR also makes database changes, it is not enought to apply the patch with patch tester, it also needs to apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package created by Drone, but that would currently not work, see my previous comment for explanation.

@alikon Please update your testing instructions to make that clear.

@crommie
Copy link

crommie commented Feb 22, 2025

Plus the notifications were already using the email templates without the patch.

@alikon
Copy link
Contributor Author

alikon commented Feb 23, 2025

as there is no entry in the #__mail_templates table before this pr on the current 5.3-dev branch
i really doubt that notification for this event use the mail template
@crommie can you clarify how you got that ?

@crommie
Copy link

crommie commented Feb 23, 2025

Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.

The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.

1 similar comment
@crommie
Copy link

crommie commented Feb 23, 2025

Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again.

The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template.

@crommie
Copy link

crommie commented Feb 23, 2025

You want me to test again on a clean site? And if so: are the PBF sites still there?

@HLeithner HLeithner changed the base branch from 5.3-dev to 6.0-dev March 4, 2025 17:19
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 6.0-dev.

@HLeithner HLeithner changed the title [5.3] New article from frontend send mail with Mailtemplate [6.0] New article from frontend send mail with Mailtemplate Mar 4, 2025
@rdeutz rdeutz removed the PR-5.3-dev label Mar 5, 2025
@alikon
Copy link
Contributor Author

alikon commented Mar 24, 2025

i'll not invest much more time on this

@alikon alikon closed this Mar 24, 2025
@alikon alikon deleted the newarticle-mailtemplate branch March 24, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.