[6.0] New article from frontend send mail with Mailtemplate#44243
[6.0] New article from frontend send mail with Mailtemplate#44243alikon wants to merge 17 commits intojoomla:6.0-devfrom
Conversation
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
|
I have tested this item ✅ successfully on db74a7f After PR: article creation ---> email notification that such and such an article was created, written by that and that. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243. |
|
I have tested this item 🔴 unsuccessfully on 014ac4e Steps Followed for Testing:
Issue Observed:
|
|
I have tested this item 🔴 unsuccessfully on 014ac4e Before: email was sent with mail template This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44243. |
|
thanks for testing and for feedback i'll re-check and i'll make it after available for test again |
|
@alikon You have to rename the update SQL scripts to something newer than the newest in the branch, which is And the PR has a conflict which needs to be resolved. If necessary I can help, but not before tonight. |
|
@komalm @crommie As this PR also makes database changes, it is not enought to apply the patch with patch tester, it also needs to apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package created by Drone, but that would currently not work, see my previous comment for explanation. @alikon Please update your testing instructions to make that clear. |
|
Plus the notifications were already using the email templates without the patch. |
|
as there is no entry in the |
|
Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again. The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template. |
1 similar comment
|
Only scenario I can think of is: I might have fired the scheduled task without enabling email, then got confused, then enabled email, applied patch, fired task, got email from email template, reverted patch, fired task and got email from template again. The only part I'm 100% sure of is I did fire it both with patch applied and with patch reverted and in both cases it used email template. |
|
You want me to test again on a clean site? And if so: are the PBF sites still there? |
|
This pull request has been automatically rebased to 6.0-dev. |
|
i'll not invest much more time on this |
Pull Request for Issue #43872 .
Summary of Changes
use the mail template instead of com_messages
Testing Instructions
apply the database changes from the update SQL script e.g. with phpMyAdmin, or to use the update package
send an article from frontend and check the email
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
the email is configurable with Mailtemplates
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed