Skip to content

[5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448#44209

Merged
Hackwar merged 2 commits intojoomla:5.2-devfrom
coolcat-creations:5.2-dev-issue43448
Nov 1, 2024
Merged

[5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448#44209
Hackwar merged 2 commits intojoomla:5.2-devfrom
coolcat-creations:5.2-dev-issue43448

Conversation

@coolcat-creations
Copy link
Contributor

Pull Request for Issue #43448

Summary of Changes

Changed the css classes so that the text is visible

Testing Instructions

Create two 2FA Methods
Log out
Login without using a method
click on "Select a different method"

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

grafik

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [ x] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [x ] No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Oct 8, 2024
@Fedik Fedik added the bug label Oct 8, 2024
@brianteeman
Copy link
Contributor

please edit this to give a meaningful title

@coolcat-creations coolcat-creations changed the title Fix for Issue #43448 Fix Dark mode in user-captive view - Fix for Issue #43448 Oct 8, 2024
@dautrich
Copy link

dautrich commented Oct 8, 2024

I have tested this item ✅ successfully on 1b7f038


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44209.

@ghost
Copy link

ghost commented Oct 9, 2024

@coolcat-creations Can you add [5.2] at begin of title so user don't have to open pull request to know on which branch it is to test?

@coolcat-creations coolcat-creations changed the title Fix Dark mode in user-captive view - Fix for Issue #43448 [5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448 Oct 9, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 1b7f038


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44209.

@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44209.

@Quy Quy changed the title [5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448 [5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448 Oct 31, 2024
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 31, 2024
@Hackwar Hackwar enabled auto-merge (squash) November 1, 2024 21:34
@Quy Quy added this to the Joomla! 5.2.1 milestone Nov 1, 2024
@Hackwar Hackwar merged commit 31640ec into joomla:5.2-dev Nov 1, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 1, 2024
@Hackwar
Copy link
Member

Hackwar commented Nov 1, 2024

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Dark Mode NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants