[5.2] use _JEXEC for restricted access#44193
Merged
pe7er merged 5 commits intojoomla:5.2-devfrom Oct 20, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on b8a737b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193. |
1 similar comment
Member
|
I have tested this item ✅ successfully on b8a737b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44193. |
Contributor
Author
|
Rebased to 5.2-dev |
Contributor
|
Thanks @heelc29 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
replace check of constant from
JPATH_BASEto_JEXECfor restricted accesslike other files eg.
joomla-cms/installation/src/Form/Rule/PrefixRule.php
Lines 14 to 16 in f2b1145
Testing Instructions
code review
Actual result BEFORE applying this Pull Request
JPATH_BASEis used for check of restricted accessExpected result AFTER applying this Pull Request
JPATH_BASEis not used for check of restricted accessLink to documentations
Please select: