[5][com_privacy] language file not loaded#44192
Merged
pe7er merged 4 commits intojoomla:5.2-devfrom Oct 16, 2024
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 7bd6402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
Contributor
|
I have tested this item ✅ successfully on 7bd6402 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44192. |
Member
|
@alikon Why for the 5.1-dev branch? There will not be any new 5.1 release. The PR should be made for the 5.2-dev branch. Could you rebase? |
Contributor
Author
|
didn't know |
Member
|
Member
|
I think it doesn’t need new test and RTC is still ok as the rebase from 5.1-dev to 5.2-dev was clean without any conflicts. |
Contributor
|
Thanks @alikon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44054
Summary of Changes
load lang file
Testing Instructions
Have a user confirm acceptance of the Privacy Policy on login (Enable the System - Privacy Consent plugin)
Go to the administrator Privacy / Consents page.
Actual result BEFORE applying this Pull Request
The Subject is a string key: PLG_SYSTEM_PRIVACYCONSENT_SUBJECT
Expected result AFTER applying this Pull Request
the Subject is a translated
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed