[5.2] Fix increment on non-alphanumeric string deprecation#44173
Merged
pe7er merged 8 commits intojoomla:5.2-devfrom Dec 2, 2024
Merged
[5.2] Fix increment on non-alphanumeric string deprecation#44173pe7er merged 8 commits intojoomla:5.2-devfrom
pe7er merged 8 commits intojoomla:5.2-devfrom
Conversation
This was referenced Oct 1, 2024
laoneo
reviewed
Oct 1, 2024
administrator/components/com_content/src/Model/ArticleModel.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on 6dc1234 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44173. |
Quy
changed the title
Quy
commented
Oct 8, 2024
administrator/components/com_newsfeeds/src/Model/NewsfeedModel.php
Outdated
Show resolved
Hide resolved
Member
|
I have tested this item ✅ successfully on 0302a85 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44173. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44173. |
Contributor
|
Thanks @Quy ! |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43896 .
Summary of Changes
Fix increment on non-alphanumeric string deprecation on php 8.3.
Testing Instructions
Enable Error Reporting to Maximum.
Create/save an article.
Create/save a banner.
Create/save a contact.
Create/save a newsfeed.
Create/save a tag.
See PHP error log.
Apply PR.
Under Publishing tab, check Revision value incrementing.
Actual result BEFORE applying this Pull Request
PHP Deprecated: Increment on non-alphanumeric string is deprecated
Expected result AFTER applying this Pull Request
No error messages.