Skip to content

Fix showon for Trigger Plugin Events in mod_articles#44155

Merged
Hackwar merged 1 commit intojoomla:5.2-devfrom
RickR2H:fix-showon
Sep 29, 2024
Merged

Fix showon for Trigger Plugin Events in mod_articles#44155
Hackwar merged 1 commit intojoomla:5.2-devfrom
RickR2H:fix-showon

Conversation

@RickR2H
Copy link
Member

@RickR2H RickR2H commented Sep 29, 2024

Pull Request for Issue # .

Summary of Changes

When the option Title Only (lists) is selected in mod_articles, the option Trigger Plugin Events is visible. This is the wrong behavior and this PR fixes the issue.

Testing Instructions

See if the option Trigger Plugin Events is hidden when Title Only (lists) is selected.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Kostelano
Copy link
Contributor

Is there a reason why this option is placed sort of in the middle of the appearance settings? I think it would look much more appropriate at the very bottom, rather than before the introductory text and below the tag settings.

@RickR2H
Copy link
Member Author

RickR2H commented Sep 29, 2024

@Kostelano In the current mod_articles_news the option is right after the show title option. So my approach was to keep is somewhere in the same position, after the header and top information. If it's really user unfriendly in a new PR the position of this option could be moved. With these kind of options it's mostly a matter of opinion as there is no direct guideline how options should be ordered for the best UI/UX.

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 9a6af1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44155.

@Hackwar Hackwar merged commit d489646 into joomla:5.2-dev Sep 29, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Sep 29, 2024
@Hackwar
Copy link
Member

Hackwar commented Sep 29, 2024

Since this is a simple fix, I'm okay with one test. Thank you @Kostelano for testing and thank you @RickR2H for your contribution.

@RickR2H RickR2H deleted the fix-showon branch September 29, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants